-
Notifications
You must be signed in to change notification settings - Fork 885
[EuiForm, EuiCallout] Added focus state to error callout #4497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
c2b8914
b9db5cf
d0b8c78
56755a0
c018b23
046689c
e160e10
84c4ea4
69703ac
4519544
22cebbe
24a9b84
447d85f
2e8d6c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,6 +80,10 @@ export const EuiForm: FunctionComponent<EuiFormProps> = ({ | |
| default="Please address the highlighted errors."> | ||
| {(addressFormErrors: string) => ( | ||
| <EuiCallOut | ||
| tabIndex={-1} | ||
| ref={(node) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is interesting. Because it creates the new
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So we need to focus the element only once, for the first mount ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tested this by adding a |
||
| node && node.focus(); | ||
| }} | ||
| className="euiForm__errors" | ||
| title={addressFormErrors} | ||
| color="danger" | ||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.