[EuiBadge] : Handle invalid color entry#4481
Conversation
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4481/ |
|
jenkins test this
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4481/ |
|
Hey @akashgp09 This looks great! It does, however, highlight the fact that our |
|
@thompsongl I have fixed it. Now it's accepting rgb string (as previously). |
thompsongl
left a comment
There was a problem hiding this comment.
LGTM! I think we will eventually want to update the validator util function(s) to accept strings withrgb(a) in the string, but this solves the more immediate problem.
I'm going to push one commit (I had it locally) to update the CL entry location. Will merge after CI passes.
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4481/ |
Signed-off-by: Akash Gupta akashgp9@gmail.com
Summary
This PR Fixes #3765
Handling invalid color entry passed to EuiBadge color prop
Checklist
- [ ] Props have proper autodocs and playground toggles