[EuiBadge] Add button type to prevent form submission#4479
Merged
thompsongl merged 5 commits intoelastic:masterfrom Feb 3, 2021
Merged
[EuiBadge] Add button type to prevent form submission#4479thompsongl merged 5 commits intoelastic:masterfrom
thompsongl merged 5 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4479/ |
chandlerprall
approved these changes
Feb 3, 2021
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Pulled & tested locally, including with & without the extra text input and/or submit button. Form submission only happened when expected.
This reverts commit 82839da.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4479/ |
This was referenced Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4273 by adding
type=buttonto the "remove" button on the EuiBadge items rendered by EuiComboBox.The problem comes from the default button
type=submitbeing triggered when Enter was hit on an input element in a form withonSubmit/action.This is half true. The combobox should indeed not react, but the form should not submit without a
type=submitelement in the form. The spec says that in a form with no submit buttons, implicit submission will be done if only one input is present.So you can see in the to-be-reverted docs change that the combobox no longer steals focus, but the form will not be submitted without uncommenting the submit input.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests