Adding whitespace prop to EuiCodeBlockProps#4475
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Thanks, @ashikmeerankutty! Could you look into refactoring the types for No problem if you can't take it on. Just let me know and I'll push a commit to this branch. |
|
@thompsongl Thanks for the review. I will refactor those types and push. |
|
@thompsongl Sorry for the delay, It seems to be the only difference between |
Nope. It's not possible to change the |
thompsongl
left a comment
There was a problem hiding this comment.
This is much cleaner; than you!
|
@thompsongl Updated the PR with the changes requested. Please do review. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4475/ |
thompsongl
left a comment
There was a problem hiding this comment.
LGTM!
Thanks, @ashikmeerankutty!
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4475/ |
|
jenkins test this flaky |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4475/ |
Summary
Fixes #4473
whitespaceprop toEuiCodeBlockPropsChecklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes