-
Notifications
You must be signed in to change notification settings - Fork 894
[Page Layouts] Adding content props to EuiPageHeader for pre-determined page layout patterns #4451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
cb8817a
Added content type props to EuiPageHeader
b54aae4
Replaced example usages with props
06afe85
Setting up a new $`euiPageDefaultMaxWidth` sass token
a2b0e6f
Updating playground & docs
c19d038
Fixin amsterdam small and reverse shadows
eff79dc
‘Fixing’ paddingSize prop on EuiPageContent
206351c
Adding custom options for `restrictWidth`
6413fb4
Starting the switch to a new component `EuiPageHeaderContent`
59643df
middle; simulate node
thompsongl 517542d
Update `useIsWithinBreakpoints` to be conditional
ea27ca0
Moving the content to a new component
20f3bb9
Cleaning up
09285bf
Playground fix
a3051f2
more customProps
thompsongl eb08a9d
Merge branch 'props/page_header' into props/page_header
cchaos b4df1a7
Merge pull request #39 from thompsongl/props/page_header
cchaos a5b6eb5
prevent format errors
thompsongl 199ade3
Merge pull request #40 from thompsongl/props/page_header
cchaos 373fa5e
Some cleanup and fixing of logic
2a59f32
Added `stretch` to the align prop and fixed tests
46929e1
Merge remote-tracking branch 'upstream/master' into props/page_header
27d7815
cl & comments
18a429b
Docs clarity
snide 5d1ea82
words
snide f6108ef
Apply suggestions from code review
cchaos 7dec3f6
Merge pull request #41 from snide/docs/pageheader
cchaos fb2c6b9
Render `<header>` element in EuiPageHeader
fc50d95
Adding `iconProps` to optional icon
e3f1ce1
Renaming `rightSideContent` to `rightSideItems` for better clarity of…
f0964c0
Replacing `rightSideResponsive` with a more generic `rightSideGroupPr…
df17134
Merge branch 'master' into props/page_header
cchaos 7d557fc
Apply suggestions from code review
cchaos f573ebb
Merge branch 'master' into props/page_header
cchaos e97d3b8
Set deprecation notice for `panelPaddingSize`
9615bcc
Merge branch 'master' into props/page_header
cchaos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,4 @@ | |
| @if (lightness($euiTextColor) < 50) { | ||
| background: $euiColorDarkestShade; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import template from '@babel/template'; | ||
|
|
||
| export const generateAst = (value) => { | ||
| return template.ast(String(value), { plugins: ['jsx'] }).expression; | ||
| }; | ||
|
|
||
| export const generateCustomProps = (props) => { | ||
| return props.reduce((obj, item) => { | ||
| return { | ||
| ...obj, | ||
| [item]: { | ||
| generate: generateAst, | ||
| }, | ||
| }; | ||
| }, {}); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.