Skip to content

Added playground to the PR checklist#4450

Merged
cchaos merged 4 commits intomasterfrom
cchaos-patch-1
Jan 28, 2021
Merged

Added playground to the PR checklist#4450
cchaos merged 4 commits intomasterfrom
cchaos-patch-1

Conversation

@cchaos
Copy link
Copy Markdown
Contributor

@cchaos cchaos commented Jan 26, 2021

Alongside the autodocs one.

@cchaos cchaos requested a review from thompsongl January 26, 2021 23:13
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4450/

@thompsongl
Copy link
Copy Markdown
Contributor

The playground config is completely undocumented right now 😬 . We should probably add at least a baseline wiki file for setup and custom handlers like simulating functions. Without it, I think we'll field all kinds of questions when a new toggle inevitably doesn't work.
I can write something up unless you want to take a pass.

@cchaos
Copy link
Copy Markdown
Contributor Author

cchaos commented Jan 27, 2021

Oh please, go ahead 😆 . Maybe I'm jumping the gun here then. There's definitely some more work to be done on the config stuff. Like I wanted to talk to you about trying to configure something where we could use the Simulate toggle for more than just a handler, but for like adding stubbed content.

@thompsongl
Copy link
Copy Markdown
Contributor

Maybe I'm jumping the gun here

If we have some docs, then I don't think so. We've been ignoring potential impacts to the playground, so this will at least bring awareness and heighten our want for improvements to the system.

Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 on board with Greg's point.

@cchaos
Copy link
Copy Markdown
Contributor Author

cchaos commented Jan 27, 2021

Yeah I definitely agree that we basically had it built, then never looked back. Part of the point of adding this bullet is to put it back on our radar so we're constantly improving.

@cchaos
Copy link
Copy Markdown
Contributor Author

cchaos commented Jan 27, 2021

And I think #4449 will help too 😉

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4450/

cchaos and others added 2 commits January 28, 2021 14:47
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4450/

@cchaos cchaos merged commit f241faf into master Jan 28, 2021
@cchaos cchaos deleted the cchaos-patch-1 branch January 28, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants