[EuiConfirmModal] Added ownFocus and isLoading props.#4421
[EuiConfirmModal] Added ownFocus and isLoading props.#4421thompsongl merged 6 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4421/ |
|
Thanks, @ashikmeerankutty! @cchaos, a couple things you mention in the issue:
Consider making
Something you want to tack on to this PR? |
cchaos
left a comment
There was a problem hiding this comment.
Consider making
ownFocuson by default?
We talked about this as a team and overall we think that it was mostly a mistake not to have included the overlay mask directly within EuiModal by default and always. EuiModal is not similar to EuiFlyout where a user could still interact with the page content below. Therefore, we will always want to obscure the content beneath the modal with the mask and we already restrict focus to within the modal too.
It does mean that most modal usages will now double display an overlay mask, so we'll want to ensure communication and/or make this change in downstream apps.
Therefore, @ashikmeerankutty , Can you remove optional ownFocus prop and always render the mask? Then we'll want to remove all manual instances of <EuiOverlayMask> within the examples.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4421/ |
f6dbe46 to
876e756
Compare
|
@cchaos Sorry for the delay updated the PR. Please do review. |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4421/ |
cchaos
left a comment
There was a problem hiding this comment.
LGTM. Just a few language polish comments. Also, you'll need to update with master so that you get the latest Changelog and can move your item to the right spot.
|
@cchaos Thanks for the review. Updated the PR with the changes. |
thompsongl
left a comment
There was a problem hiding this comment.
LGTM
Thanks, @ashikmeerankutty!
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4421/ |
Summary
Fixes #4411
Added ownFocus and isLoading props to EuiConfirmModal
Checklist
- [ ] Checked Code Sandbox works for the any docs examples