[EuiMarkdownEditor] Add a markdown link validator #4362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4362/ |
chandlerprall
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4362/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4362/ |
thompsongl
reviewed
Dec 8, 2020
thompsongl
approved these changes
Dec 8, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Changes LGTM. Don't forget a changelog entry
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4362/ |
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4331
markdown parsing
https://eui.elastic.co/pr_4362/#/editors-syntax/markdown-editor
Look how only the valid urls get rendered as links, and the rest render their text. Ooooh. Ahhhh. Valid markdown links start with http:/https: or a forward slash.
href validation
https://eui.elastic.co/pr_4362/#/navigation/link#link-validation
EuiLink docs updated with a section on the validation. I [Chandler] initially planned on creating a new prop to disable the validation, but with React planning on similarly removing this functionality I'm going to be optimistic that no one will miss having this option available. In contrast to markdown's validation which only allows a small approved list of url patterns, the href validation only prevents
javascript:.Components affected:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes