Skip to content

[EuiToolTip] Prevent from closing while moving to intial position #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thompsongl merged 4 commits into from
Dec 3, 2020
Merged

[EuiToolTip] Prevent from closing while moving to intial position #4327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e347081
visibility hidden while positioning
thompsongl Dec 1, 2020
af2a945
clean up
thompsongl Dec 1, 2020
517c74f
Merge branch 'master' into tooltip-flicker
thompsongl Dec 2, 2020
fa297cf
CL
thompsongl Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

**Bug fixes**

- Expose `EuiErrorBoundary` error message not showing in non-Chromium browsers ([#4324](https://github.com/elastic/eui/pull/4324))
- Fixed `EuiErrorBoundary` error message not showing in non-Chromium browsers ([#4324](https://github.com/elastic/eui/pull/4324))
- Fixed `EuiToolTip` closing during initial positioning period ([#4327](https://github.com/elastic/eui/pull/4327))

**Theme: Amsterdam**

Expand Down
3 changes: 3 additions & 0 deletions src/components/tool_tip/tool_tip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ interface ToolTipStyles {
left: number | 'auto';
right?: number | 'auto';
opacity?: number;
visibility?: 'hidden';
}

const displayToClassNameMap = {
Expand All @@ -75,6 +76,8 @@ const DEFAULT_TOOLTIP_STYLES: ToolTipStyles = {
// just in case, avoid any potential flicker by hiding
// the tooltip before it is positioned
opacity: 0,
// prevent accidental mouse interaction while positioning
visibility: 'hidden',
};

export interface Props {
Expand Down