Skip to content

[EuiButtonEmpty] Adjust font size in Amsterdam and add more colors #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreadelrio merged 13 commits into from
Dec 3, 2020
Merged

[EuiButtonEmpty] Adjust font size in Amsterdam and add more colors #4325

andreadelrio merged 13 commits into from
Dec 3, 2020

Conversation

@andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Dec 1, 2020 •
edited
Loading

Summary

  • [Amsterdam] Reduced font size for the xs size.
  • Added warning and success colors.
  • I also added the new colors to the docs examples and simplified the example as I felt it was getting a bit repetitive.

Checklist

  • Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
    - [ ] Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@andreadelrio andreadelrio requested a review from cchaos December 1, 2020 02:51
@kibanamachine
Copy link

kibanamachine commented Dec 1, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4325/

cchaos
cchaos suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes/additions! Just had a couple extra suggestions.

@andreadelrio andreadelrio requested a review from cchaos December 2, 2020 19:08
@kibanamachine
Copy link

kibanamachine commented Dec 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4325/

cchaos
cchaos approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM!

@kibanamachine
Copy link

kibanamachine commented Dec 3, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_4325/

@andreadelrio andreadelrio merged commit a1d469d into elastic:master Dec 3, 2020
@chandlerprall chandlerprall mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreadelrio @kibanamachine @cchaos