Skip to content

[EuiFilterGroup] and [EuiFilterButton] Fix styling for Amsterdam #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2020
Merged

[EuiFilterGroup] and [EuiFilterButton] Fix styling for Amsterdam #4151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
658fab6
[EuiFilterGroup] and [EuiFilterButton] Fix styling for Amsterdam
Oct 16, 2020
2c5609a
Better fix for faux-borders
Oct 16, 2020
7b1844d
Merge remote-tracking branch 'upstream/master' into ams/filter_group
Oct 16, 2020
e6846ba
cl
Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
**Theme: Amsterdam**

- Tightened `line-height` for some `EuiTitle` sizes ([4133](https://github.com/elastic/eui/pull/4133))
- Fixed `EuiFilterGroup` and `EuiFilterButton` styles ([4151](https://github.com/elastic/eui/pull/4151))

## [`29.5.0`](https://github.com/elastic/eui/tree/v29.5.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/filter_group/_filter_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
max-width: 100%;
border-right: 1px solid $euiFormBorderColor;
box-shadow: 0 1px 2px -1px transparentize($euiShadowColor, .8), 0 3px 3px -2px transparentize($euiShadowColor, .8);
overflow-x: auto;
overflow: hidden;

> * {
flex: 1 1 auto;
Expand Down
16 changes: 16 additions & 0 deletions src/themes/eui-amsterdam/overrides/_filter_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
.euiFilterGroup {
border: none;
border-radius: $euiFormControlBorderRadius;
background-color: $euiFormBackgroundColor;
box-shadow: inset 0 0 0 1px $euiFormBorderColor;
}

.euiFilterButton {
border-radius: 0;
border: none;
background-color: transparent;
// Box shadow simulates bottom and left borders
box-shadow: 0 1px 0 0 $euiFormBorderColor, -1px 0 0 0 $euiFormBorderColor;

.euiFilterButton--withNext + & {
// Remove just the left faux border
box-shadow: 0 1px 0 0 $euiFormBorderColor;
}
}