Skip to content

Make sidenav coloring more consistant for open nodes #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Make sidenav coloring more consistant for open nodes #3926

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b89ca9
Style change to sidenav
snide Aug 16, 2020
6a8a454
Merge remote-tracking branch 'upstream/master' into fix/sidenav
snide Aug 17, 2020
18770a4
cl
snide Aug 17, 2020
f65adfa
feedback
snide Aug 18, 2020
ab5cade
Merge remote-tracking branch 'upstream/master' into fix/sidenav
snide Aug 18, 2020
7f1b47f
feeback for caroline and her eagle eye
snide Aug 18, 2020
835eabc
Merge branch 'master' into fix/sidenav
cchaos Aug 19, 2020
8d39b29
Add value props to EuiSelect props (#3934)
ashikmeerankutty Aug 19, 2020
e4833f3
Show extended interfaces in docs page (#3941)
ashikmeerankutty Aug 19, 2020
134f305
Add vertical scroll and text highlighting for functions (#3918)
ashikmeerankutty Aug 19, 2020
6efa5b4
ML icon updates (#3931)
mdefazio Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Adjusted coloring of `EuiSideNav` to be more consistent across open states ([#3926](https://github.com/elastic/eui/pull/3926))

**Bug fixes**

- Fixed bug in `EuiBasicTable` not fully expanding tall rows (height > 1000px) ([#3855](https://github.com/elastic/eui/pull/3855))
Expand Down
23 changes: 14 additions & 9 deletions src/components/side_nav/_side_nav_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
display: block;
width: 100%;
padding: $euiSizeXS / 2 0;
color: $euiColorFullShade; /* 2 */
color: $euiTextColor; /* 2 */

&.euiSideNavItemButton--isClickable {
&:hover .euiSideNavItemButton__label {
Expand All @@ -23,9 +23,13 @@
}

&.euiSideNavItemButton-isSelected {
.euiSideNavItemButton__icon {
fill: $euiColorPrimary;
}

.euiSideNavItemButton__label {
color: $euiColorPrimary;
font-weight: $euiFontWeightMedium;
font-weight: $euiFontWeightBold;
text-decoration: underline;
}
}
Expand All @@ -48,7 +52,7 @@
}

.euiSideNavItemButton__label {
color: $euiColorDarkShade;
color: $euiTitleColor;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
Expand Down Expand Up @@ -148,12 +152,13 @@
& > .euiSideNavItem__items {
margin-left: $euiSize;
}
}

.euiSideNavItem--hasChildItems {
& > .euiSideNavItemButton-isOpen {
.euiSideNavItemButton__label {
color: $euiColorFullShade;
}
.euiSideNavItemButton__icon {
fill: $euiTextSubduedColor;
}

.euiSideNavItemButton__label {
color: $euiTextSubduedColor;
}
}