Fixes EuiComboBox Label not calculated correctly#3501
Fixes EuiComboBox Label not calculated correctly#3501thompsongl merged 5 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| getSelectedOptionForSearchValue?: ( | ||
| searchValue: string, | ||
| selectedOptions: any[] | ||
| ) => EuiComboBoxOptionOption<T>; | ||
| ) => EuiComboBoxOptionOption<T> | undefined; |
There was a problem hiding this comment.
why using undefined here when ? at the end of getSelectedOptionForSearchValue already suggests that undefined is acceptable
There was a problem hiding this comment.
If undefined is not given. It creates a lint error. I guess, In this case, the props value is undefined not the prop.
There was a problem hiding this comment.
In this case, the props value is undefined not the prop
Correct. The ? allows for getSelectedOptionForSearchValue itself to be undefined.
(getSelectedOptionForSearchValue={undefined})
But adding | undefined allows for the value returned by the getSelectedOptionForSearchValue function to be undefined
(getSelectedOptionForSearchValue={(booleanParam) => booleanParam ? 'hello' : undefined})
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3501/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3501/ |
4 participants
Summary
Fixes #3458
getSelectedOptionForSearchValuetoEuiComboBoxOptionsListoptions list as prop.Before:
After:
I think this was missed during the typescript conversion #2838
Checklist
- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes