Skip to content

Fix EuiPopover arrow position in Android and Linux #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elizabetdev merged 4 commits into from
Mar 31, 2020
Merged

Fix EuiPopover arrow position in Android and Linux #3188

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebe86b1
moves popover bottom arrow closer to parent box
dimitropoulos Mar 29, 2020
4537087
updates changelog
dimitropoulos Mar 29, 2020
6bcac88
Update CHANGELOG.md
elizabetdev Mar 31, 2020
8f3b25e
Update CHANGELOG.md
elizabetdev Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Improved edge case for `EuiPopover` arrow subpixel rendering bug ([#3188](https://github.com/elastic/eui/pull/3188))
Comment thread
elizabetdev marked this conversation as resolved.
Outdated
- Improved `htmlIdGenerator` when supplying both `prefix` and `suffix` ([#3076](https://github.com/elastic/eui/pull/3076))

## [`22.2.0`](https://github.com/elastic/eui/tree/v22.2.0)
Expand Down
4 changes: 2 additions & 2 deletions src/components/popover/_popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@

&.euiPopover__panelArrow--top {
&:before {
bottom: -$euiPopoverArrowSize + 1;
bottom: -$euiPopoverArrowSize + 2;
border-left: $euiPopoverArrowSize solid transparent;
border-right: $euiPopoverArrowSize solid transparent;
border-top: $euiPopoverArrowSize solid $euiBorderColor;
}

&:after {
bottom: -$euiPopoverArrowSize + 2;
bottom: -$euiPopoverArrowSize + 3;
border-left: $euiPopoverArrowSize solid transparent;
border-right: $euiPopoverArrowSize solid transparent;
border-top: $euiPopoverArrowSize solid $euiColorEmptyShade;
Expand Down