Removed moz border on focus from EuiSelect#3178
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@snide please review. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3178/ |
|
@snide please review. |
|
The focus has been removed but there is another problem arising in dark mode. Needs a little bit of correction by changing the style differently for different modes. Will do that in quick succession. |
| } | ||
| &:-moz-focusring { | ||
| color: transparent; | ||
| text-shadow: 0 0 0 #000; |
There was a problem hiding this comment.
You will need to use SASS vars for colors as you see above in the IE fix.
You should also turn linting on in your editor and not skip the pre-commit hooks which would have alerted you to the errors here.
|
Also, in order for us to better review this PR, please provide a detailed summary as to your approach to fixing the issue. You will also need to add a Changelog entry. You can follow the guidelines in the Contributing doc. |
Summary
Fixes #3171
Checklist