Skip to content

Add elasticsearch specific field type tokens#3165

Merged
mdefazio merged 13 commits intoelastic:masterfrom
mdefazio:icons-tokens-es
Mar 30, 2020
Merged

Add elasticsearch specific field type tokens#3165
mdefazio merged 13 commits intoelastic:masterfrom
mdefazio:icons-tokens-es

Conversation

@mdefazio
Copy link
Copy Markdown
Contributor

@mdefazio mdefazio commented Mar 25, 2020 •
edited
Loading

Summary

Adds the following tokens to the EUI token list.
Will close elastic/kibana#58036
Will close elastic/kibana#61003

  • Binary
  • Completion Suggester
  • Flattened
  • Join
  • Dense Vector
  • Keyword
  • Percolator
  • Rank feature
  • Rank features
  • Token Count
  • Text
  • Search-as-you-type
  • Histogram

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@mdefazio mdefazio self-assigned this Mar 25, 2020
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 25, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 25, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@mdefazio mdefazio marked this pull request as ready for review March 26, 2020 14:56
@mdefazio mdefazio added the icons label Mar 26, 2020
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Mar 26, 2020

@mdefazio Can you add screenshots of the design files for each so we can view the pixel grid alignment?

alisonelizabeth
alisonelizabeth approved these changes Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons LGTM in the preview documentation. Thanks for working on this @mdefazio!

@mdefazio
Copy link
Copy Markdown
Contributor Author

mdefazio commented Mar 27, 2020

I had a feeling you were going to ask @cchaos ;)

As I mentioned, the completion suggester isn't aligned yet as I knew I wanted to tweak that anyway. Should have a new version shortly though.

image

cjcenizal
cjcenizal approved these changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@mdefazio
Copy link
Copy Markdown
Contributor Author

mdefazio commented Mar 30, 2020

Updated screenshot of tokens with grid
image

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Mar 30, 2020

Something funky is happening with the DnD tests. @mdefazio Can you revert just the changes to the drag-and-drop snapshots?

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Mar 30, 2020

Also, don't forget to add a changelog entry.

@mdefazio
Revert "Update tests"
47dec28 
This reverts commit 2756a28.
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

cchaos
cchaos approved these changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing 🎉 Tokens lgtm. Some of the 1.5 strokes are slightly fuzzy on non-retina's but because they're thicker rather than thinner than 1px, you the lines are still visible.

Still, don't forget to add a changelog entry.

cchaos
cchaos reviewed Mar 30, 2020
View reviewed changes
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

1 similar comment
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3165/

@mdefazio mdefazio merged commit a5d1cba into elastic:master Mar 30, 2020
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 31, 2020
Closed
@elizabetdev elizabetdev mentioned this pull request Oct 11, 2021
Merged
6 tasks
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Oct 21, 2021

@mdefazio It looks like these tokens are missing from our Figma library. Can you add them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cchaos cchaos cchaos approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdefazio mdefazio

Labels

icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discover token for Histogram type fields [Design] More visual mappings (EuiTokenMap) for specific ES field types

5 participants

@mdefazio @kibanamachine @cchaos @cjcenizal @alisonelizabeth