Prevent checkbox focus ring from getting clipped in tables#2770
Merged
andreadelrio merged 5 commits intoelastic:masterfrom Jan 17, 2020
Merged
Prevent checkbox focus ring from getting clipped in tables#2770andreadelrio merged 5 commits intoelastic:masterfrom
andreadelrio merged 5 commits intoelastic:masterfrom
Conversation
snide
reviewed
Jan 17, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Noticed this was a draft after I made the comment, but it looks pretty good when I tested. Nice work.
ryankeairns
reviewed
Jan 17, 2020
CHANGELOG.md
Outdated
|
|
||
| **Bug fixes** | ||
|
|
||
| - Removed inline width from `EuiTableHeaderCellCheckbox`in `EuiBasicTable` to prevent `EuiCheckbox`'s focus ring from getting clipped ([#2770](https://github.com/elastic/eui/pull/2770)) |
Contributor
There was a problem hiding this comment.
Maybe reword this to be about increasing the width... "- Increased column width on EuiTableHeaderCellCheckox in..."
ryankeairns
approved these changes
Jan 17, 2020
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM. Checked it out locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customtable example to use 32px as width for the checkbox column.EuiTableHeaderCellCheckboxfromEuiBasicTable.Fixes #2757
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes