Skip to content

Lighten hollow badge border in dark mode #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryankeairns merged 4 commits into from
Jan 9, 2020
Merged

Lighten hollow badge border in dark mode #2746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83d7b44
Lighten hollow badge border in dark mode
ryankeairns Jan 9, 2020
20775ba
add CHANGELOG
ryankeairns Jan 9, 2020
3fbf4e5
Update CHANGELOG.md
ryankeairns Jan 9, 2020
c2d329a
Merge branch 'master' into rk/hollow-badge-dark
ryankeairns Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Lightened `EuiBadge` hollow border color in dark mode ([#2746](https://github.com/elastic/eui/pull/2746))
- Added `minInputProps` and `maxInputProps` to supply more props to the inputs of `EuiDualRange` ([#2738](https://github.com/elastic/eui/pull/2738))
- Changed `EuiBadge` to use EUI palette colors ([#2455](https://github.com/elastic/eui/pull/2455))
- Darkened a few `euiPaletteColorBlind` colors ([#2455](https://github.com/elastic/eui/pull/2455))
Expand Down
2 changes: 1 addition & 1 deletion src/components/badge/_badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@
// Hollow has a border and is mostly used for autocompleters.
.euiBadge--hollow {
background-color: $euiColorEmptyShade;
border-color: $euiBorderColor;
border-color: lightOrDarkTheme($euiBorderColor, tint($euiBorderColor, 15%));
color: $euiTextColor;
}