Fixed bug in datagrid where Hide fields columns were cached#2725
Merged
chandlerprall merged 8 commits intoelastic:masterfrom Jan 6, 2020
Merged
Conversation
Contributor
CI failure, but I get this locally also |
Contributor
Author
|
Apparently our version of (jest|jest-babel|@babel/preset-typescript|something) doesn't support the |
thompsongl
approved these changes
Jan 2, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Confirmed it fixes the problem using the test case in the issue
Contributor
Author
|
jenkins test this |
Contributor
Author
|
@thompsongl I renamed the hook to |
thompsongl
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2606
EuiDataGridwhere an updated column list was not reflected in the "Hide fields" popoveruseResettingStatecustom hook, a pattern I've used a couple places and decided to formalize for this (open to better name suggestions)/cc @walterra
Checklist
- [ ] Check against all themes for compatability in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes