-
Notifications
You must be signed in to change notification settings - Fork 861
EuiFieldNumber: converted to Typescript #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thompsongl
merged 6 commits into
elastic:master
from
ffknob:convert-EuiFieldNumber-to-TS
Dec 19, 2019
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d43c786
Converts EuiFieldNumber to Typescript
ffknob 4f44b92
Adds PR number
ffknob 72a228c
Merge branch 'master' into convert-EuiFieldNumber-to-TS
ffknob d19b4f2
Removes unnecessary function
ffknob 6dd9809
Merge branch 'master' into convert-EuiFieldNumber-to-TS
ffknob a95d20c
Fixes what was requested in the PR's review
ffknob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import React, { InputHTMLAttributes, Ref, FunctionComponent } from 'react'; | ||
| import { CommonProps } from '../../common'; | ||
| import classNames from 'classnames'; | ||
|
|
||
| import { EuiFormControlLayout } from '../form_control_layout'; | ||
|
|
||
| import { EuiValidatableControl } from '../validatable_control'; | ||
|
|
||
| export type EuiFieldNumberProps = InputHTMLAttributes<HTMLInputElement> & | ||
| CommonProps & { | ||
| value?: number | ''; | ||
| icon?: string; | ||
| isInvalid?: boolean; | ||
| fullWidth?: boolean; | ||
| isLoading?: boolean; | ||
| readOnly?: boolean; | ||
| min?: number; | ||
| max?: number; | ||
| step?: number; | ||
| inputRef?: Ref<HTMLInputElement>; | ||
|
|
||
| /** | ||
| * Creates an input group with element(s) coming before input | ||
| */ | ||
| prepend?: JSX.Element | JSX.Element[]; | ||
|
|
||
| /** | ||
| * Creates an input group with element(s) coming after input | ||
| */ | ||
| append?: string; | ||
|
|
||
| /** | ||
| * Completely removes form control layout wrapper and ignores | ||
| * icon, prepend, and append. Best used inside EuiFormControlLayoutDelimited. | ||
| */ | ||
| controlOnly?: boolean; | ||
|
|
||
| /** | ||
| * when `true` creates a shorter height input | ||
| */ | ||
| compressed?: boolean; | ||
| }; | ||
|
|
||
| export const EuiFieldNumber: FunctionComponent<EuiFieldNumberProps> = ({ | ||
| className, | ||
| icon, | ||
| id, | ||
| placeholder, | ||
| name, | ||
| min, | ||
| max, | ||
| value, | ||
| isInvalid, | ||
| fullWidth, | ||
| isLoading, | ||
| compressed, | ||
| prepend, | ||
| append, | ||
| inputRef, | ||
| readOnly, | ||
| controlOnly, | ||
| ...rest | ||
| }) => { | ||
| const classes = classNames('euiFieldNumber', className, { | ||
| 'euiFieldNumber--withIcon': icon, | ||
| 'euiFieldNumber--fullWidth': fullWidth, | ||
| 'euiFieldNumber--compressed': compressed, | ||
| 'euiFieldNumber--inGroup': prepend || append, | ||
| 'euiFieldNumber-isLoading': isLoading, | ||
| }); | ||
|
|
||
| const control = ( | ||
| <EuiValidatableControl isInvalid={isInvalid}> | ||
| <input | ||
| type="number" | ||
| id={id} | ||
| min={min} | ||
| max={max} | ||
| name={name} | ||
| value={value} | ||
| placeholder={placeholder} | ||
| readOnly={readOnly} | ||
| className={classes} | ||
| ref={inputRef} | ||
| {...rest} | ||
| /> | ||
| </EuiValidatableControl> | ||
| ); | ||
|
|
||
| if (controlOnly) { | ||
| return control; | ||
| } | ||
|
|
||
| return ( | ||
| <EuiFormControlLayout | ||
| icon={icon} | ||
| fullWidth={fullWidth} | ||
| isLoading={isLoading} | ||
| compressed={compressed} | ||
| readOnly={readOnly} | ||
| prepend={prepend} | ||
| append={append} | ||
| inputId={id}> | ||
| {control} | ||
| </EuiFormControlLayout> | ||
| ); | ||
| }; | ||
|
|
||
| EuiFieldNumber.defaultProps = { | ||
| value: undefined, | ||
| fullWidth: false, | ||
| isLoading: false, | ||
| compressed: false, | ||
| }; | ||
ffknob marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.