Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS#2382
Merged
pugnascotia merged 5 commits intoelastic:masterfrom Sep 27, 2019
Merged
Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS#2382pugnascotia merged 5 commits intoelastic:masterfrom
EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TS#2382pugnascotia merged 5 commits intoelastic:masterfrom
Conversation
chandlerprall
suggested changes
Sep 26, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes look good; requesting some changes around exports in the source files, some of which will need to be added to the corresponding index.ts files as well to ensure they're exported to the top module level
thompsongl
reviewed
Sep 26, 2019
pugnascotia
force-pushed
the
oh-i-like-to-ts-migrate
branch
from
751ec9a to
97dc135
Compare
Contributor
Author
|
Ready for another review pass. |
snide
pushed a commit
to snide/eui
that referenced
this pull request
Oct 10, 2019
…tic#2382) Migrate EuiFacetGroup, EuiKeyPadMenu and EuiCallOut to TypeScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
EuiFacetGroup,EuiKeyPadMenuandEuiCallOutto TypeScript.Checklist