Skip to content

Add stacked chart icons#2379

Merged
ryankeairns merged 1 commit intoelastic:masterfrom
ryankeairns:rk/icons-stacked-charts
Sep 26, 2019
Merged

Add stacked chart icons#2379
ryankeairns merged 1 commit intoelastic:masterfrom
ryankeairns:rk/icons-stacked-charts

Conversation

@ryankeairns
Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns commented Sep 25, 2019

Summary

Add three new stacked chart icons which are variations on existing icons: visAreaStacked, visBarVerticalStacked, and visBarHorizontalStacked.

Light and dark

Screenshot 2019-09-25 16 59 45

Screenshot 2019-09-25 16 59 20

Sketch

(the peaks and valleys on the area chart align between the top and bottom series)

Screenshot 2019-09-25 17 01 02

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns force-pushed the rk/icons-stacked-charts branch from f7a251e to 94c2391 Compare September 25, 2019 22:09
@ryankeairns ryankeairns requested a review from cchaos September 25, 2019 22:10
@ryankeairns ryankeairns marked this pull request as ready for review September 25, 2019 22:10
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ryankeairns ryankeairns merged commit 313ff91 into elastic:master Sep 26, 2019
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants