Skip to content

Export drag and drop service methods#2377

Merged
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:bug/2372-export-dragndrop-methods
Sep 26, 2019
Merged

Export drag and drop service methods#2377
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:bug/2372-export-dragndrop-methods

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall commented Sep 25, 2019

Summary

Fixes #2372 by exporting the copy, move, and reorder drag-and-drop service methods. I tested by building EUI with this change and requireing the built package into node, verifying the three methods exist as expected.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only question would be if we want to export these with less generic names...

@chandlerprall
Copy link
Copy Markdown
Contributor Author

@thompsongl yeah that's a good call; we don't have a strong precedent here (TBH not even a weak one). They don't need to be discoverable except through the docs, so I'm thinking something like dndCopy dndMove and dndReorder - what do you think?

pinging @snide @cchaos for your thoughts as well

@thompsongl
Copy link
Copy Markdown
Contributor

No strong preference on what the names are. I think the dnd prefix works.

@snide
Copy link
Copy Markdown
Contributor

snide commented Sep 26, 2019

I'd continue with the eui prefix if possible so folks know where it's coming from. euiDragDropCopy...etc.

@chandlerprall
Copy link
Copy Markdown
Contributor Author

I've updated the method names to euiDragDrop*, and did so at their creation (previously was renaming them at the last export) so our docs would reflect the correct name.

Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chandlerprall chandlerprall merged commit 640f75e into elastic:master Sep 26, 2019
@chandlerprall chandlerprall deleted the bug/2372-export-dragndrop-methods branch September 26, 2019 15:23
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
* Export move, copy, and reorder drag-and-drop service methods

* changelog

* Update dnd service method names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export reorder function

3 participants