Skip to content

Make EuiTableRowCell textOnly={false} when its an expanded row#2376

Merged
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:feature/2370-non-textonly-expanded-table-rows
Sep 25, 2019
Merged

Make EuiTableRowCell textOnly={false} when its an expanded row#2376
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:feature/2370-non-textonly-expanded-table-rows

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

Summary

Closes #2370. Hard codes textOnly={false} on EuiBasicTable`'s expanded rows. This allows the content to properly grow to the full width of the expanded row.

/cc @justinkambic

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@chandlerprall chandlerprall merged commit 3565991 into elastic:master Sep 25, 2019
@chandlerprall chandlerprall deleted the feature/2370-non-textonly-expanded-table-rows branch September 25, 2019 19:06
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
…ic#2376)

* Make EuiTableRowCell textOnly={false} when its an expanded row

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable textOnly for expanded rows in EuiBasicTable

2 participants