Adjusted style of beta badge on EuiKeyPadMenuItem#2375
Merged
cchaos merged 3 commits intoelastic:masterfrom Sep 27, 2019
Merged
Adjusted style of beta badge on EuiKeyPadMenuItem#2375cchaos merged 3 commits intoelastic:masterfrom
cchaos merged 3 commits intoelastic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beta badge was competing for attention with the icon and the strokes were making the area very buys.
Before
So I simply darkened the color of the icon, lightly added a background color and removed the border.
After
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes