Skip to content

Fixed bug where Array.prototype.slice() may have been called on 'undefined' #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snide merged 3 commits into from
Sep 24, 2019
Merged

Fixed bug where Array.prototype.slice() may have been called on 'undefined' #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65f873
Update popover.tsx
2bit-hack Sep 24, 2019
cdc376e
Update CHANGELOG.md
2bit-hack Sep 24, 2019
5d778c5
Update CHANGELOG.md
2bit-hack Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
**Bug fixes**

- Fixed spacing of `EuiFormErrorText` to match `EuiFormHelpText` ([#2354](https://github.com/elastic/eui/pull/2354))
- Fixed bug in `EuiPopover` where Array.prototype.slice() may have been called on 'undefined' ([#2369](https://github.com/elastic/eui/pull/2369))

## [`14.2.0`](https://github.com/elastic/eui/tree/v14.2.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export class EuiPopover extends Component<Props, State> {

// for each child element of `this.panel`, find any transition duration we should wait for before stabilizing
const { durationMatch, delayMatch } = Array.prototype.slice
.call(this.panel ? this.panel.children : undefined)
.call(this.panel ? this.panel.children : [])
.reduce(
({ durationMatch, delayMatch }, element) => {
const transitionTimings = getTransitionTimings(element);
Expand Down