Skip to content

use euiFocusBackgroundColor for EuiFacetButton :focus #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbharding merged 7 commits into from
Sep 25, 2019
Merged

use euiFocusBackgroundColor for EuiFacetButton :focus #2365

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
302d21c
use for EuiFacetButton :focus
hbharding Sep 23, 2019
b4b8c58
Updated changelog
hbharding Sep 24, 2019
777592d
removed trailing whitespace
hbharding Sep 24, 2019
d567193
fixed indentation
hbharding Sep 24, 2019
4c3ba96
fixed my mistake / leftover code
hbharding Sep 24, 2019
e29bec8
use euiSizeXS instead of px value
hbharding Sep 24, 2019
c25600f
merge upstream master
hbharding Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Modified `EuiFacetButton` to use `$euiFocusBackgroundColor` for `:focus` state ([2365](https://github.com/elastic/eui/pull/2365))

**Bug fixes**

- Fixed spacing of `EuiFormErrorText` to match `EuiFormHelpText` ([#2354](https://github.com/elastic/eui/pull/2354))
Expand Down
4 changes: 3 additions & 1 deletion src/components/facet/_facet_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
}

&:focus {
background-color: $euiColorLightestShade;
background-color: $euiFocusBackgroundColor;
// use box-shadow as a "faux outline" to apply left/right padding only
box-shadow: -4px 0 $euiFocusBackgroundColor, 4px 0 $euiFocusBackgroundColor;

@cchaos cchaos Sep 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have variables for pixel values that you'll want to use

Suggested change
box-shadow: -4px 0 $euiFocusBackgroundColor, 4px 0 $euiFocusBackgroundColor;
box-shadow: (-$euiSizeXS) 0 $euiFocusBackgroundColor, $euiSizeXS 0 $euiFocusBackgroundColor;

}

&:disabled {
Expand Down