Add data-test-subj support to non-custom table actions#2353
Merged
chandlerprall merged 8 commits intoelastic:masterfrom Sep 24, 2019
Merged
Conversation
cchaos
approved these changes
Sep 23, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
It works for me. Just had one suggestion around the naming of an EUI dts.
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
chandlerprall
deleted the
feature/1807-data-test-subj-on-table-actions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1807
I added a
data-test-subjto the collapsed actions button and allowed properties on default action types (non-custom actions can already specify the data-test-subj however they'd like). TheAdding actions to BasicTabledoc section was updated to includedata-test-subjs and can be used to verify they are applied to the DOM in the three non-custom action locations:/cc @lizozom @pheyos
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Checked for accessibility including keyboard-only and screenreader modes