Skip to content

EuiNavDrawer: Fix title text of dock/undock icon #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchaos merged 2 commits into from
Aug 27, 2019
Merged

EuiNavDrawer: Fix title text of dock/undock icon #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cc687a
EuiNavDrawer: Fix title text of dock/undock icon
Aug 27, 2019
249b3fa
cl
Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Fixed `EuiSuperDatePicker` to update `asyncInterval.isStopped` on a `isPaused` prop change. ([#2250](https://github.com/elastic/eui/pull/2250))
- Converted table, popover, buttons, pagination, outside click detector, focus trap, context menu, and panel to TypeScript ([#2212](https://github.com/elastic/eui/pull/2212))
- Fixed `EuiStat` invalid DOM nesting due to a `<p>` tag nested within another `<p>` tag ([#2229](https://github.com/elastic/eui/pull/2229))
- Fixed title text of dock/undock icon in `EuiNavDrawer` ([#2229](https://github.com/elastic/eui/pull/2229))

**Reverts**

Expand Down
4 changes: 2 additions & 2 deletions src/components/nav_drawer/nav_drawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ export class EuiNavDrawer extends Component {
iconSize: 's',
'aria-label': sideNavLockAriaLabel,
title: this.state.isLocked
? sideNavLockCollapsed
: sideNavLockExpanded,
? sideNavLockExpanded
: sideNavLockCollapsed,
'aria-checked': this.state.isLocked ? true : false,
role: 'switch',
}}
Expand Down