Skip to content

Range ts #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryia-lapata merged 9 commits into from
Aug 15, 2019
Merged

Range ts #2211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d3e44b9
Add TS for onChange in EUIRange
maryia-lapata Aug 8, 2019
9449520
Merge branch 'master' into range-ts
maryia-lapata Aug 8, 2019
36897e9
Update CHANGELOG.md
maryia-lapata Aug 8, 2019
acb97a6
Update index.d.ts
maryia-lapata Aug 8, 2019
2892624
Merge branch 'master' into range-ts
maryia-lapata Aug 12, 2019
1c28ee5
Apply code review comments
maryia-lapata Aug 12, 2019
6f21143
Merge branch 'master' into range-ts
maryia-lapata Aug 14, 2019
bd2804a
Merge branch 'master' into range-ts
maryia-lapata Aug 15, 2019
de4268b
Update CHANGELOG.md
maryia-lapata Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Fixed `EuiSwitch` semantics to align with aria roles ([#2193](https://github.com/elastic/eui/pull/2193))
- Removed Firefox's focus ring to match other browsers ([#2193](https://github.com/elastic/eui/pull/2193))
- Added missing `onChange` TS defs for EuiRange ([#2211](https://github.com/elastic/eui/pull/2211))

## [`13.3.0`](https://github.com/elastic/eui/tree/v13.3.0)

Expand Down
7 changes: 7 additions & 0 deletions src/components/form/range/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ declare module '@elastic/eui' {
tickInterval?: number;
valueAppend?: ReactNode;
valuePrepend?: ReactNode;

onChange?: (
event:
| React.ChangeEvent<HTMLInputElement>
| React.MouseEvent<HTMLButtonElement>,
isValid: boolean
) => void;
}

export const EuiRange: FunctionComponent<
Expand Down