Skip to content

Update docs on how to test local EUI in Kibana#2144

Merged
snide merged 5 commits intomasterfrom
patch-docs
Jul 19, 2019
Merged

Update docs on how to test local EUI in Kibana#2144
snide merged 5 commits intomasterfrom
patch-docs

Conversation

@snide
Copy link
Contributor

@snide snide commented Jul 19, 2019

Summary

yarn link no longer works. Updated the docs to give people options for something that does.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from chandlerprall July 19, 2019 20:06
@snide snide added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Jul 19, 2019
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both methods works as described -- just takes forever... haha. Had come copy suggestions.

snide and others added 3 commits July 19, 2019 13:28
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@snide snide merged commit 3a437bb into master Jul 19, 2019
@snide snide deleted the patch-docs branch July 19, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants