Skip to content

Remove EuiFlexGroup dependency from EuiAccordion #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchaos merged 6 commits into from
Jul 22, 2019
Merged

Remove EuiFlexGroup dependency from EuiAccordion #2143

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c995cbb
Removed dependency from button
Jul 19, 2019
6cb6ec3
Remove outer dependency
Jul 19, 2019
478e5ec
Fix up docs
Jul 19, 2019
92282d5
cl
Jul 19, 2019
f0b5440
Update src-docs/src/views/accordion/accordion_multiple.js
cchaos Jul 22, 2019
3cbcb3b
Remove unused class `euiAccordion__buttonContent`
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Added `EuiSuggestItem` component ([#2090](https://github.com/elastic/eui/pull/2090))
- Added support for negated or clauses to `EuiSearchBar` ([#2140](https://github.com/elastic/eui/pull/2140))
- Added `transition` utility services to help create timeouts that account for CSS transition durations and delays ([#2136](https://github.com/elastic/eui/pull/2136))
- Removed `EuiFlexGroup` dependency from `EuiAccordion` ([#2143](https://github.com/elastic/eui/pull/2143))

**Bug fixes**

Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/accordion/accordion_form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const repeatableForm = (

const buttonContent = (
<div>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexGroup gutterSize="s" alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiIcon type="logoWebhook" size="m" />
</EuiFlexItem>
Expand Down
3 changes: 2 additions & 1 deletion src-docs/src/views/accordion/accordion_multiple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export default () => (

<EuiAccordion
id="accordion2"
buttonContent="A second accordion with padding"
buttonContent="A second accordion with padding and a very long title that should truncate because of eui-textTruncate"
Comment thread
cchaos marked this conversation as resolved.
Outdated
buttonContentClassName="eui-textTruncate"
paddingSize="l">
<EuiText>
<p>The content inside can be of any height.</p>
Expand Down
Loading