Convert a range of EuiRange* components to TypeScript#2124
Merged
thompsongl merged 8 commits intoelastic:masterfrom Jul 16, 2019
Merged
Convert a range of EuiRange* components to TypeScript#2124thompsongl merged 8 commits intoelastic:masterfrom
EuiRange* components to TypeScript#2124thompsongl merged 8 commits intoelastic:masterfrom
Conversation
Contributor
I've got the converted |
Contributor
Author
A separate PR for larger |
chandlerprall
suggested changes
Jul 16, 2019
chandlerprall
approved these changes
Jul 16, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled and testing locally. Needs a changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A range of them 😏
Unfortunately, we can't yet convert the full suite as
EuiFieldNumberis still JS.Checked generated
eui.d.tsin Kibana successfully.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components