Centered the square of the popout icon in the artboard#2120
Merged
cchaos merged 3 commits intoelastic:masterfrom Jul 15, 2019
Merged
Centered the square of the popout icon in the artboard#2120cchaos merged 3 commits intoelastic:masterfrom
cchaos merged 3 commits intoelastic:masterfrom
Conversation
ryankeairns
reviewed
Jul 12, 2019
ryankeairns
reviewed
Jul 12, 2019
snide
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caroline's being nit-picky again
I noticed in Kibana when using this icon next to text, the fact that the whole path was centered in the artboard made the icon look off0centered.
I find that the square is the most dominant shape and should be centered in the Artboard
Uncentered (before) vs Centered (after)
So now it lines up with the text better (Top being the before)
Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components