EuiFormRow with nested EuiPopovers using ownFocus#2110
Merged
thompsongl merged 6 commits intoelastic:masterfrom Jul 15, 2019
Merged
EuiFormRow with nested EuiPopovers using ownFocus#2110thompsongl merged 6 commits intoelastic:masterfrom
EuiFormRow with nested EuiPopovers using ownFocus#2110thompsongl merged 6 commits intoelastic:masterfrom
Conversation
chandlerprall
approved these changes
Jul 15, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; tested locally, not seeing performance issues from the focus fight
Member
|
Thanks so much for the fast turnaround on this! 🎉 |
This was referenced Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lots of manual testing welcome
Discussed primarily in #eui Slack, the issue as raised by @legrego shows serious performance problems resulting from DOM
focusupdates inEuiPopover.Causes
.contains()to prevent unnecessaryfocusupdates, which simply doesn't cut it when portals get involved.EuiPopoveris likely too eager to manually changefocusduring itscomponentDidUpdatemethod.Solution
No. 1 is a real thing we (and every other app in the React ecosystem) need to solve. The best answer is likely to let React fix it with the proposed
FocusManagerAPI.We have full control over No. 2, so that's where to start.
Events where updating
focusshould happenEuiFocusTraphandles this case and returns focus to the last active elementEuiFocusTraphas already (correctly) removed focus from the popoverinitialFocusandownFocusare the only props relevant to focus. Neither should alter an already open popover. They will update on subsequent open calls.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This required updates to Framer X components