Skip to content

Pass EuiSuperSelect's popoverClassName to the popover's panel #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zumwalt merged 3 commits into from
Jun 20, 2019
Merged

Pass EuiSuperSelect's popoverClassName to the popover's panel #2068

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e0748d
Pass EuiSuperSelect's popoverClassName to the popover's panel
zumwalt Jun 20, 2019
aadad60
Merge branch 'master' into zumwalt/super-select-panel-classname
zumwalt Jun 20, 2019
d6fff15
Merge branch 'master' into zumwalt/super-select-panel-classname
zumwalt Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Added a fully black (no matter the theme) color SASS variable `$euiColorInk` ([2060](https://github.com/elastic/eui/pull/2060))
- Added `autoFocus` prop to `EuiTabbedContent` ([2062](https://github.com/elastic/eui/pull/2062))
- Changed `popout` glyph in `EuiIcon` to look more like external link ([2064](https://github.com/elastic/eui/pull/2064))
- Pass `EuiSuperSelect`'s `popoverClassName` to the popover's panel ([#2068](https://github.com/elastic/eui/pull/2068))

**Bug fixes**

Expand Down
6 changes: 5 additions & 1 deletion src/components/form/super_select/super_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ export class EuiSuperSelect extends Component {
popoverClassName
);

const popoverPanelClasses = classNames('euiSuperSelect__popoverPanel', {
[`${popoverClassName}__popoverPanel`]: !!popoverClassName,

@cchaos cchaos Jun 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the brackets necessary? Shouldn't it just be:

Suggested change
[`${popoverClassName}__popoverPanel`]: !!popoverClassName,
`${popoverClassName}__popoverPanel`: !!popoverClassName,

@zumwalt zumwalt Jun 20, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like they’re required for dynamic class names: https://github.com/JedWatson/classnames/blob/master/README.md#dynamic-class-names-with-es2015

@cchaos cchaos Jun 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I guess this is the first time we've used this pattern. 👍

});

const buttonClasses = classNames(
{
'euiSuperSelect--isOpen__button': this.state.isPopoverOpen,
Expand Down Expand Up @@ -232,7 +236,7 @@ export class EuiSuperSelect extends Component {
<EuiPopover
className={popoverClasses}
anchorClassName="euiSuperSelect__popoverAnchor"
panelClassName="euiSuperSelect__popoverPanel"
panelClassName={popoverPanelClasses}
button={button}
isOpen={isOpen || this.state.isPopoverOpen}
closePopover={this.closePopover}
Expand Down