Merged
Conversation
Enable webpack's production mode in the docs build so that the output bundles are minified. Also configure the output to include '[name]', so that each chunk is named correctly. Clear out old assets from `docs/` as well.
pugnascotia
added
documentation
Contributor
I want to note that this changes the gzipped bundle from 3Mb to 1.7Mb 🥇 |
chandlerprall
approved these changes
Jun 18, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; tested locally with the instructions in the description and verified significant decrease in over-the-wire bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables webpack's production mode in the docs build so that the output bundles are minified. Also configure the output to include '[name]', so that each chunk is named correctly. Clear out old assets from
docs/as well.I tested the results with:
yarn build-docscd docspython3 -m http.serverhttp://0.0.0.0:8000/Note that the main bundle is still about 8MB, but shrinking that is a job for another day.