Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c9a153c
Added ariaLabel customization way for <checkbox> in tables;
PhilippBaranovskiy Jun 14, 2019
79ccf71
Update CHANGELOG
PhilippBaranovskiy Jun 14, 2019
f92b73d
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 17, 2019
38bfbc1
Updated CHANGELOG; Added a note about `ariaLabel` to selection table …
PhilippBaranovskiy Jun 17, 2019
6123738
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 17, 2019
a8d239c
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 18, 2019
76b628c
Replace adding additional prop with passing modifier function
PhilippBaranovskiy Jun 18, 2019
31f838b
Merge branch '1697' of https://github.com/rockfield/eui into 1697
PhilippBaranovskiy Jun 18, 2019
6163584
cleaning up
PhilippBaranovskiy Jun 18, 2019
7b84251
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
df6c87b
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
442f86d
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
8f53c08
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
d546c8a
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
4be6c7c
Update src-docs/src/views/tables/selection/selection_section.js
PhilippBaranovskiy Jun 18, 2019
9f2aef6
Update selection_section.js
PhilippBaranovskiy Jun 18, 2019
96ee295
Replace getAriaLabel with using title
PhilippBaranovskiy Jun 18, 2019
e477e2e
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 18, 2019
7338302
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 19, 2019
cfc0f4b
syntax updates
PhilippBaranovskiy Jun 19, 2019
60cdce8
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
faa9c72
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
648a2d8
Reverting docs back
PhilippBaranovskiy Jun 19, 2019
7c9dca9
Updated CHANGELOG
PhilippBaranovskiy Jun 19, 2019
5dce07e
Updated snapshots.
PhilippBaranovskiy Jun 19, 2019
f3d8221
Merge branch 'master' into 1697
PhilippBaranovskiy Jun 24, 2019
3ea689a
review updates
PhilippBaranovskiy Jun 24, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Changed `EuiNavDrawerFlyout` title from `h5` to `div` ([#2040](https://github.com/elastic/eui/pull/2040))
- Fixed proptype for `EuiCopy`'s `children` ([#2048](https://github.com/elastic/eui/pull/2048))
- Added `ariaLabel` prop's value of the the selection checkbox in table items (for each row) in `EuiBasicTable` as a result of modifier function passed with with items ([#2043](https://github.com/elastic/eui/pull/2043))

## [`12.0.0`](https://github.com/elastic/eui/tree/v12.0.0)

Expand Down
4 changes: 4 additions & 0 deletions src-docs/src/views/tables/selection/selection.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ export class Table extends Component {
onSelectionChange: this.onSelectionChange,
};

const getAriaLabel = (item = {}) =>
`${item.firstName || ''} ${item.lastName || ''}`;

return (
<Fragment>
{deleteButton}
Expand All @@ -214,6 +217,7 @@ export class Table extends Component {
sorting={sorting}
isSelectable={true}
selection={selection}
getAriaLabel={getAriaLabel}
onChange={this.onTableChange}
/>
</Fragment>
Expand Down
10 changes: 8 additions & 2 deletions src-docs/src/views/tables/selection/selection_section.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ export const section = {
text: (
<p>
The following example shows how to configure selection via the{' '}
<EuiCode>selection</EuiCode>
property.
<EuiCode>selection</EuiCode> property.
<br />
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
This is important to provide an <EuiCode>getAriaLabel</EuiCode> modifier
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
function of selection table to supply a valuable screen reader user{' '}
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
experience.
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
<br />
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
If no modifier function is provided, then default aria-label value is{' '}
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
<EuiCode>Select this row</EuiCode>.
Comment thread
PhilippBaranovskiy marked this conversation as resolved.
Outdated
</p>
),
components: { EuiBasicTable },
Expand Down
Loading