Skip to content

[Firefox] Remove background-color from transition property list of form control mixin #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchaos merged 2 commits into from
May 7, 2019
Merged

[Firefox] Remove background-color from transition property list of form control mixin #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c891d6
Remove `background-color` from transition property list of form contr…
May 7, 2019
0e33089
cl
May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `10.4.0`
**Bug fixes**

- Fixed Firefox flash of unstyled select dropdown ([#1927](https://github.com/elastic/eui/pull/1927))

## [`10.4.0`](https://github.com/elastic/eui/tree/v10.4.0)

Expand Down
11 changes: 9 additions & 2 deletions src/components/form/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,16 @@

transition:
box-shadow $euiAnimSpeedFast ease-in,
background-color $euiAnimSpeedFast ease-in,
background-image $euiAnimSpeedFast ease-in,
background-size $euiAnimSpeedFast ease-in;
background-size $euiAnimSpeedFast ease-in,
background-color $euiAnimSpeedFast ease-in;

// Fixes bug in Firefox where adding a transition to the background-color
// caused a flash of differently styled dropdown.
@supports (-moz-appearance: none) { // sass-lint:disable-line no-vendor-prefixes
// List *must* be in the same order as the above.
transition-property: box-shadow, background-image, background-size;
}
}

@mixin euiFormControlFocusStyle($borderOnly: false) {
Expand Down