[Wiki] React Router 5.x does not provide React Context#1778
Merged
Conversation
This corrects the previous edit suggesting that `react-router` 5.0 was completely backward compatible with 4.x. It turns out, while trying to use this trick to extract the `context` within the constructor that `this.context.router` is `undefined`. I _assume_ that we just need to use a context consumer, but I do not see its name or type documented anywhere.
pickypg
added
the
documentation
cjcenizal
approved these changes
Mar 28, 2019
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Thanks for doing this! Looks great, just had a couple suggestions about a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the previous edit suggesting that
react-router5.0was completely backward compatible with 4.x.
It turns out, while trying to use this trick to extract the
contextwithin the constructor that
this.context.routerisundefined.I assume that we just need to use a context consumer, but I
do not see its name or type documented anywhere.
I also shortened the code examples a tiny bit.