Headings, and <p>, need to inherit#1776
Merged
cchaos merged 2 commits intoelastic:masterfrom Mar 28, 2019
Merged
Conversation
Contributor
Author
|
@formgeist Originally caught this in the KQL autocomplete:
|
Contributor
Author
|
And here's what it now looks like in Kibana:
As well as the originally issue
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the previous fix of #1760 where setting the font size at the reset level was causing these tags not to inherit from their container. Even the text scales weren't working:
So now, all 3 properties are just set to inherit (which should be from the
htmltag which does set the size, family and weight.Now:
back to normal
Checklist
[ ] This was checked in mobile[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components