Close nav drawer when a link is clicked#1773
Merged
ryankeairns merged 1 commit intoelastic:masterfrom Mar 27, 2019
Merged
Conversation
10 tasks
ryankeairns
force-pushed
the
rk/close-nav-click
branch
from
8ff852d to
57cd3dd
Compare
Contributor
|
Have you |
Contributor
Author
|
@cchaos yep |
This was referenced Mar 27, 2019
1 task
Shigawire
pushed a commit
to Shigawire/eui
that referenced
this pull request
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change will fix a Kibana issue elastic/kibana#30331 where the expanded nav drawer will remain open if you navigate to the app that you are already viewing. In other words, there is no refresh so the menu doesn't get reloaded to the collapsed state. I noticed this can also happen with the flyout - if it's open and you click on an app icon in the main menu, the flyout stays open. This PR addresses both cases.
Reviewer note
This solution was the outcome of some discussion an initial PR - #1770
Demo
Checklist
This required updates to Framer X components