Move react-datepicker types into EUI#1618
Merged
chandlerprall merged 5 commits intoelastic:masterfrom Feb 27, 2019
Merged
Conversation
jasonrhodes
reviewed
Feb 27, 2019
…rprall/eui into remove-types-reactdatepicker-dep
jasonrhodes
approved these changes
Feb 27, 2019
Member
jasonrhodes
left a comment
jasonrhodes
left a comment
There was a problem hiding this comment.
With my added changes, this passes in Kibana :D
Contributor
Author
|
Thanks again @jasonrhodes ! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attempts to resolve same issue as #1607 , but by inlining the react-datepicker TS defs into EUI. I verified
ReactDatePickerandReactDatePickerPropsare exported out of@elastic/euimodule so consumers can use the same type defs if needed.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components