Merged
Conversation
Contributor
|
Hmm, can we put the toggle in a less prominent place in the docs? Maybe it's another option in the dropdown? @snide ? |
Contributor
|
Yep. I'll provide a design PR for this tomorrow. Off hand a gear popover that has all these kinds of toggles in one place would be good. I think we can also likely remove the K6 themes (not the dist) from the docs at this point since EUI should essentially be locked for 6.x now. |
pugnascotia
reviewed
Feb 7, 2019
scripts/babel/fetch-i18n-strings.js
Outdated
| } | ||
|
|
||
| function handleJSXPath(path) { | ||
| if (path.node.name.name === 'EuiI18n') { |
Contributor
There was a problem hiding this comment.
This is also checked below, for the JSXOpeningElement handler. Is it needed here also?
pugnascotia
reviewed
Feb 7, 2019
scripts/babel/fetch-i18n-strings.js
Outdated
| } | ||
|
|
||
| (async () => { | ||
| const files = (await asyncGlob( |
Contributor
There was a problem hiding this comment.
You could use glob.sync to simplify things.
pugnascotia
reviewed
Feb 7, 2019
| const CHARS_FOR_PSEUDO_LOCALIZATION_REGEX = /[a-z]/gi; | ||
|
|
||
| /** | ||
| * Replaces every latin char by pseudo char and repeats every third char twice. |
Contributor
There was a problem hiding this comment.
Iä! Iä! Cthulhu fhtagn!
Merged
pugnascotia
approved these changes
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-doing PR from #1512 as I managed to merge that (and then revert it) while writing this summary.
Huge thanks to @lizozom for initial setup for this work.
toggle for pseudo-translation, showing text that has been localized
Toggle is only present in development environments. It's kinda ugly, could use a design pass.
new I18n Tokens docs page
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components