Change flex-basis for EuiPageBody#1497
Merged
ryankeairns merged 2 commits intoelastic:masterfrom Jan 30, 2019
Merged
Conversation
c082247 to
385f818
Compare
cchaos
approved these changes
Jan 30, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Thanks for taking the time to test it in all those environments!
Contributor
|
Great, thanks for the fix @ryankeairns ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sebelga reported an IE11 layout issue within Management (screenshot below) where the layout would break for larger screen sizes. After digging in, the cause was related to the
EuiPageBodyhaving aflex-basis: 0%value. Changing this value to100%makes the page body center itself properly in IE11 while continuing to work in other browsers as well.This change was tested in Kibana, Cloud, and EUI docs on IE11, Edge, Firefox, Safari and Chrome.
Notes: This issue was only observed on the Management views where there is a second side navigation and where there are kui column layouts (div containers) being used for sections within
EuiPage. In this situation, IE11 displays the content in the center of section, however it does so from the left edge of the content when theflex-basisis0%.Checklist
Documentation examples were addedJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components