Skip to content

fix EuiSuperSelect from accessing ref when unmounted #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 2 commits into from
Dec 13, 2018
Merged

fix EuiSuperSelect from accessing ref when unmounted #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a371a4
fix EuiSuperSelect from accessing ref when unmounted
nreese Dec 13, 2018
53b8d60
change log
nreese Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Added `anchorClassName` prop to `EuiPopover` ([#1367](https://github.com/elastic/eui/pull/1367))
- Added support for `fullWidth` on `EuiSuperSelect` ([#1367](https://github.com/elastic/eui/pull/1367))
- Applied new scrollbar customization for Firefox ([#1367](https://github.com/elastic/eui/pull/1367))
- Fixed `EuiSuperSelect` from accessing ref when unmounted ([1369](https://github.com/elastic/eui/pull/1369))

## [`5.7.0`](https://github.com/elastic/eui/tree/v5.7.0)

Expand Down
11 changes: 11 additions & 0 deletions src/components/form/super_select/super_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ export class EuiSuperSelect extends Component {
};
}

componentDidMount() {
this._isMounted = true;
}

componentWillUnmount() {
this._isMounted = false;
}

setItemNode = (node, index) => {
this.itemNodes[index] = node;
};
Expand All @@ -48,6 +56,9 @@ export class EuiSuperSelect extends Component {
);

requestAnimationFrame(() => {
if (!this._isMounted) {
return;
}
this.setState({
menuWidth: this.popoverRef.getBoundingClientRect().width - 2, // account for border not inner shadow
});
Expand Down