Reinstate combobox onblur pill creation in #1353 and fix bug in initial implementation#1364
Merged
cjcenizal merged 5 commits intoelastic:masterfrom Dec 11, 2018
Merged
Conversation
…n initial implementation.
Contributor
|
I would think EuiComboBox shouldn't call |
Contributor
Author
|
Good idea @chandlerprall. I've made the change, could you please take another look? |
chandlerprall
approved these changes
Dec 11, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled locally and played with the combobox docs
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were actually two bugs in the original bug report from Kibana, one on the EUI side and one on the Kibana side.
The EUI bug was caused by the internal
onBlurcallback also being called when the combo box is focused. I'm not sure why this is the case, but we can work around it by ensuring the input doesn't have focus before trying to create an option. I've added a test which would have caught this the first time around.On the Kibana side, a bug exists in which empty string input isn't being validated and ignored correctly. I suspect this might be a common mistake when using the combo box, so I've added a note to check for this in the release notes. CC @elastic/kibana-security.