Allow setting basic aria attributes on EuiCodeEditor#1354
Merged
timroes merged 3 commits intoelastic:masterfrom Dec 10, 2018
Merged
Allow setting basic aria attributes on EuiCodeEditor#1354timroes merged 3 commits intoelastic:masterfrom
timroes merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@chandlerprall could you clarify if I need to do anything for that "autodocs" todo? The ARIA attributes are in the default attributes, and not explicitly stated in any component right now? |
chandlerprall
approved these changes
Dec 7, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM; pulled & tested locally
Contributor
|
@timroes no need for the autodocs, those props are assumed present |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
aria-label,aria-labelledbyandaria-describedbyto theEuiCodeEditorcomponent. This is required to fix things like elastic/kibana#22973.Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] This was checked in dark mode[ ] This was checked for breaking changes and labeled appropriately[ ] This required updates to Framer X components