Skip to content

Fix combobox full width size#1314

Merged
cchaos merged 2 commits intoelastic:masterfrom
cchaos:fix-combobox-sizing-again
Nov 16, 2018
Merged

Fix combobox full width size#1314
cchaos merged 2 commits intoelastic:masterfrom
cchaos:fix-combobox-sizing-again

Conversation

@cchaos
Copy link
Contributor

@cchaos cchaos commented Nov 16, 2018

Summary

Ugh... good catch @cjcenizal

Fixes #1313

Before

Full width & compressed
screen shot 2018-11-16 at 11 15 04 am

After

Full width & compressed
screen shot 2018-11-16 at 11 15 22 am

Checklist

  • This was checked in mobile
  • This was checked in IE11
    - [ ] This was checked in dark mode
    - [ ] Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
    ~- [ ] This was checked for breaking changes and labeled appropriately`
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@cchaos cchaos requested a review from cjcenizal November 16, 2018 16:20
@cjcenizal
Copy link
Contributor

Thanks for moving on this so quickly @cchaos!

@cchaos cchaos merged commit 247108a into elastic:master Nov 16, 2018
@cchaos cchaos deleted the fix-combobox-sizing-again branch November 16, 2018 16:57
@snide snide mentioned this pull request Nov 30, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants