Add TS defs for badges, popover titles, and other fixes#1299
Merged
pugnascotia merged 5 commits intoelastic:masterfrom Nov 8, 2018
Merged
Add TS defs for badges, popover titles, and other fixes#1299pugnascotia merged 5 commits intoelastic:masterfrom
pugnascotia merged 5 commits intoelastic:masterfrom
Conversation
Ensure tab TS definitions are included in the main definition index. The definitions were added in a previous PR, but not included in the main index.d.ts file. Also fix an issue in the build where a required directly wasn't being created.
chandlerprall
suggested changes
Nov 8, 2018
src/components/badge/index.d.ts
Outdated
| } | ||
|
|
||
| export const EuiBetaBadge: SFC< | ||
| CommonProps & HTMLAttributes<HTMLSpanElement> & HTMLAttributes<HTMLButtonElement> & EuiBetaBadgeProps |
Contributor
There was a problem hiding this comment.
I don't see any use of a button in EuiBetaBadge
src/components/badge/index.d.ts
Outdated
| } | ||
|
|
||
| export const EuiNotificationBadge: SFC< | ||
| CommonProps & HTMLAttributes<HTMLSpanElement> & HTMLAttributes<HTMLButtonElement> |
Contributor
There was a problem hiding this comment.
I don't see any use of a button in EuiNotificationBadge
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TS defs for beta and notifications badges, and popover titles.
Fix the main TS index file so that tab definitions are included.
Fix the build to ensure all required directories are created.